Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): move read permissions to job scope #95

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

miketheman
Copy link
Collaborator

Setting permissions at the Job level, this overrides the parent contents: read setting, failing for private repositories.

Setting permissions at the Job level, this overrides the parent `contents: read` setting, failing for private repositories.
@miketheman miketheman added the bugfix Fixes a known bug label Oct 31, 2024
@miketheman miketheman requested a review from woodruffw October 31, 2024 21:48
@woodruffw woodruffw merged commit d9d0419 into main Oct 31, 2024
4 checks passed
@woodruffw woodruffw deleted the miketheman/fix-ci-perms branch October 31, 2024 21:50
miketheman added a commit to miketheman/warehouse that referenced this pull request Oct 31, 2024
Refs: woodruffw/zizmor#95

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants